[PATCH] D105683: [AMDGPU] Allow frontends to disable null export for pixel shaders

[Ruiling, Song via Phabricator via llvm-commits]

ruiling added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SILateBranchLowering.cpp:76
   // "null export"
-  if (IsPS) {
+  if (IsPS && HasExports) {
     BuildMI(MBB, I, DL, TII->get(AMDGPU::EXP_DONE))
----------------
Do you think we need to define a subtarget feature like AllowNoExportPS and check it here? The hardware behavior is different before and after gfx10, if we do not check this hardware difference, then this attributes will be gpu-generation-dependent (frontend should not set this attribute before gfx10). I am not sure whether this sounds a issue to others?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105683/new/

https://reviews.llvm.org/D105683