[PATCH] D105782: [lld/mac] Always reference dyld_stub_binder when linked with libSystem

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 11 10:28:54 PDT 2021


int3 accepted this revision.
int3 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/MachO/Driver.cpp:1049
+  // StubHelperSection::setup() adds a reference and errors out if the symbol
+  // isn't exist in case the symbol is actually needed.
+  symtab->addUndefined("dyld_stub_binder", /*file=*/nullptr, /*isWeak=*/false);
----------------
can we make it clear that this isn't needed for correctness (as far as we know)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105782/new/

https://reviews.llvm.org/D105782



More information about the llvm-commits mailing list