[PATCH] D105780: [Attributes] Determine attribute properties from TableGen data

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 11 09:37:01 PDT 2021


nikic added inline comments.


================
Comment at: llvm/include/llvm/IR/Attributes.td:14
+/// Attribute property base class.
+class AttrProperty;
+
----------------
madhur13490 wrote:
> What about a better name - something like, AttrPlace or AttrLocation?
This is intended as a generic mechanism for specifying metadata about attributes. Right now it only specifies where it can be placed, but there's more properties we can track. For example, it would be nice to replace this switch: https://github.com/llvm/llvm-project/blob/98c2e4115d8d7d4962df52f595e8d2d0cfdfdc8f/llvm/lib/Transforms/Utils/CodeExtractor.cpp#L893


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105780/new/

https://reviews.llvm.org/D105780



More information about the llvm-commits mailing list