[PATCH] D105762: [X86] Teach X86FloatingPoint's handleCall to only erase the FP stack if there is a regmask operand that clobbers the FP stack.

Kadir SELÇUK via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 10 20:21:38 PDT 2021


post.kadirselcuk planned changes to this revision.
post.kadirselcuk marked an inline comment as done.
post.kadirselcuk added inline comments.


================
Comment at: llvm/lib/Target/X86/X86FloatingPoint.cpp:995
+      for (unsigned i = 1; i != 8; ++i)
+        assert(Op.clobbersPhysReg(X86::FP0 + i) == ClobbersFP0 &&
+               "Inconsistent FP register clobber");
----------------
craig.topper wrote:
> pengfei wrote:
> > Why can't the callee only clobber one or a few registers?
> The later code that calls popReg until the stack is empty would need to be updated in a non-trivial way to handle that.
finish? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105762/new/

https://reviews.llvm.org/D105762



More information about the llvm-commits mailing list