[llvm] 8cb7d71 - [OpenMP][FIX] Add missing `)` to remark

Johannes Doerfert via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 10 16:56:23 PDT 2021


Author: Johannes Doerfert
Date: 2021-07-10T18:40:32-05:00
New Revision: 8cb7d71355f9ca884efde1dfa03dc349fb890721

URL: https://github.com/llvm/llvm-project/commit/8cb7d71355f9ca884efde1dfa03dc349fb890721
DIFF: https://github.com/llvm/llvm-project/commit/8cb7d71355f9ca884efde1dfa03dc349fb890721.diff

LOG: [OpenMP][FIX] Add missing `)` to remark

Added: 
    

Modified: 
    llvm/lib/Transforms/IPO/OpenMPOpt.cpp
    llvm/test/Transforms/OpenMP/custom_state_machines_remarks.ll

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/IPO/OpenMPOpt.cpp b/llvm/lib/Transforms/IPO/OpenMPOpt.cpp
index c9b0ee008074..ceb2d8295c23 100644
--- a/llvm/lib/Transforms/IPO/OpenMPOpt.cpp
+++ b/llvm/lib/Transforms/IPO/OpenMPOpt.cpp
@@ -2871,7 +2871,7 @@ struct AAKernelInfoFunction : AAKernelInfo {
           return ORA
                  << "State machine fallback caused by this call. If it is a "
                     "false positive, use "
-                    "`__attribute__((assume(\"omp_no_openmp\"))` "
+                    "`__attribute__((assume(\"omp_no_openmp\")))` "
                     "(or \"omp_no_parallelism\").";
         };
         A.emitRemark<OptimizationRemarkAnalysis>(

diff  --git a/llvm/test/Transforms/OpenMP/custom_state_machines_remarks.ll b/llvm/test/Transforms/OpenMP/custom_state_machines_remarks.ll
index 850b24f45a24..d7383f853519 100644
--- a/llvm/test/Transforms/OpenMP/custom_state_machines_remarks.ll
+++ b/llvm/test/Transforms/OpenMP/custom_state_machines_remarks.ll
@@ -2,8 +2,8 @@
 target triple = "nvptx64"
 
 ; CHECK: remark: llvm/test/Transforms/OpenMP/custom_state_machines_remarks.c:11:1: Generic-mode kernel is executed with a customized state machine that requires a fallback [1 known parallel regions, 2 unkown parallel regions] (bad)
-; CHECK: remark: llvm/test/Transforms/OpenMP/custom_state_machines_remarks.c:13:5: State machine fallback caused by this call. If it is a false positive, use `__attribute__((assume("omp_no_openmp"))` (or "omp_no_parallelism")
-; CHECK: remark: llvm/test/Transforms/OpenMP/custom_state_machines_remarks.c:15:5: State machine fallback caused by this call. If it is a false positive, use `__attribute__((assume("omp_no_openmp"))` (or "omp_no_parallelism")
+; CHECK: remark: llvm/test/Transforms/OpenMP/custom_state_machines_remarks.c:13:5: State machine fallback caused by this call. If it is a false positive, use `__attribute__((assume("omp_no_openmp")))` (or "omp_no_parallelism")
+; CHECK: remark: llvm/test/Transforms/OpenMP/custom_state_machines_remarks.c:15:5: State machine fallback caused by this call. If it is a false positive, use `__attribute__((assume("omp_no_openmp")))` (or "omp_no_parallelism")
 ; CHECK: remark: llvm/test/Transforms/OpenMP/custom_state_machines_remarks.c:20:1: Generic-mode kernel is executed with a customized state machine [1 known parallel regions] (good)
 
 ;; void unknown(void);


        


More information about the llvm-commits mailing list