[PATCH] D105596: [PowerPC] Custom Lowering BUILD_VECTOR for v2i64 for P7 as well

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added a comment.

I took a brief look at the custom lowering for `BUILD_VECTOR` and as far as I can tell, we correctly guard within that function (and functions it calls). So I don't think there is really an issue with removing this guard.
That being said, I'd like to see a statement about thorough testing of this patch. What I would like to see is at least a bootstrap with `-mcpu=pwr7` for both LE and BE. Honestly, I don't actually know if we can successfully bootstrap on LE with `-mcpu=pwr7` but if we do it would be good to test that with this patch as well. Of course, I realize that LE isn't supposed to be supported with Power7, but AFAIK it works just fine and may trigger some more issues. All we are really interested in are compiler crashes such as selection errors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105596/new/

https://reviews.llvm.org/D105596