[PATCH] D105532: [llvm-readobj] Switch command line parsing from llvm::cl to OptTable

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 9 16:10:35 PDT 2021


MaskRay marked 7 inline comments as done.
MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-readobj/llvm-readobj.cpp:567
+    // This needs to contain the word "GNU", libtool looks for that string.
+    outs() << "llvm-nm, compatible with GNU nm" << '\n';
+    cl::PrintVersionMessage();
----------------
jhenderson wrote:
> Might want to fix this line ;) (actually do you need it at all?)
There was no `llvm-readobj` line previously. So I don't add it.

Previously there was a buggy line: the "registered targets" is always "none" because `InitializeAll*` is done too late. I assume this lines don't matter so I delete them.
```
  Registered Targets:
    (none)
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105532/new/

https://reviews.llvm.org/D105532



More information about the llvm-commits mailing list