[PATCH] D104355: [GlobalISel] Add a new artifact combiner for unmerge which looks through general artifact expressions.
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 9 16:06:33 PDT 2021
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM with nit
================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h:690
+ return findValueFromDef(SrcRegToUse, NewStartBit, Size);
+ } else if (InsertOffset <= StartBit && EndBit <= InsertedEndBit) {
+ SrcRegToUse = InsertedReg;
----------------
No return after else
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104355/new/
https://reviews.llvm.org/D104355
More information about the llvm-commits
mailing list