[PATCH] D105720: [AsmParser] Add support to LOCAL directive.

Jian Cai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 9 14:51:32 PDT 2021


jcai19 added inline comments.


================
Comment at: llvm/lib/MC/MCParser/AsmParser.cpp:2505
+    std::size_t Pos = 0;
+    std::unordered_set<std::string> Locals;
+
----------------
nickdesaulniers wrote:
> would it be preferable to use `llvm::StringSet`?
> 
> https://llvm.org/docs/ProgrammersManual.html#llvm-adt-stringset-h
Sounds good! Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105720/new/

https://reviews.llvm.org/D105720



More information about the llvm-commits mailing list