[PATCH] D105733: [OpaquePtr] Require matching signature in getCalledFunction()

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 9 14:35:00 PDT 2021


dblaikie added a comment.

Probably a reasonable path forward - though I worry this is creating some subtle technical debt where callers will expect that getCalledFunction's result is null/non-null in the same places where the Function is a direct parameter. (but, yeah, no doubt there's already technical debt that assumes they're the same type - so it's a bit of a loss either way)

This is probably the lesser pain & we'll have to fix up whatever cases come up as it comes up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105733/new/

https://reviews.llvm.org/D105733



More information about the llvm-commits mailing list