[PATCH] D70350: [DWARF] Allow cross-CU references of subprogram definitions

Fri Jul 9 14:28:26 PDT 2021

vsk added a subscriber: jmorse.
vsk added a comment.

In D70350#2867905 <https://reviews.llvm.org/D70350#2867905>, @kyulee wrote:

> @vsk As commented in https://bugs.llvm.org/show_bug.cgi?id=48790, this seems to impact us when building a large app with LTO even in XCode.
> I don't have a cutdown but it showed up frequently blocking us stack traces with symbolication. Have we considered fixing this or backing out this change?

@jmorse has a patch up that should address an issue with definition DIEs not being created in the unit referenced by their subprogram: D94976 <https://reviews.llvm.org/D94976>. I haven't caught up with the discussion there.

The impact of backing out this change would be that backtraces including artificial tail call frames and parameter entry value evaluation would to an appreciable extent stop working in some of our key internal projects.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70350/new/

https://reviews.llvm.org/D70350