[PATCH] D105485: [IR] Use a proper type for AttributeList indexing

[Clement Courbet via Phabricator via llvm-commits]

courbet accepted this revision.
courbet added a comment.
This revision is now accepted and ready to land.

Nice!



================
Comment at: llvm/include/llvm/IR/Attributes.h:444
+  static Index getArgIndex(unsigned ArgNo) { return Index::fromArgNo(ArgNo); }
+  static const Index ReturnIndex;
+  static const Index FunctionIndex;
----------------
`constexpr` ?


================
Comment at: llvm/lib/Transforms/Utils/AssumeBundleBuilder.cpp:212
                               Attr.hasAttribute(Attribute::Alignment);
-          if (!IsPoisonAttr || Call->isPassingUndefUB(Idx - 1))
-            addAttribute(Attr, Call->getArgOperand(Idx - 1));
----------------
This was broken, right ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105485/new/

https://reviews.llvm.org/D105485