[PATCH] D105279: [RemoveRedundantDebugValues] Introduce a MIR pass that removes redundant DBG_VALUEs

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added inline comments.


================
Comment at: llvm/test/DebugInfo/NVPTX/debug-loc-offset.ll:250
+; CHECK-NEXT: .b8 0                                // EOM(2)
+; CHECK-NEXT: .b8 8                                // Abbreviation Code
 ; CHECK-NEXT: .b8 36                               // DW_TAG_base_type
----------------
djtodoro wrote:
> aprantl wrote:
> > Why did this change, is it because the order in which the DBG_VALUEs are processed is different now?
> Now we have a new abbrev since the parameter becomes `DW_AT_const_value`:
> 
>    ...
>      (1)  DBG_VALUE 0, $noreg, !13, !DIExpression(), debug-location !14
>      (2) DBG_VALUE 1, $noreg, !13, !DIExpression(), debug-location !14
>    ...
> 
> This will consider the (1) as redundant...is this OK?
I’d say it isn’t good…We need to take into account the DBG_VALUEs with a constant as the first operand as a special case…


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105279/new/

https://reviews.llvm.org/D105279