[PATCH] D105013: [InstCombine] try to fold the expression "(A & ~B) + B" to "A | B"

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 9 13:07:34 PDT 2021


spatel added a comment.

In D105013#2866272 <https://reviews.llvm.org/D105013#2866272>, @dongAxis1944 wrote:

> gentle ping @spatel @lebedev.ri

I don't think you've accounted for commutation in the tests. Did you see the existing test examples that have the comment "thwart complexity-based canonicalization"?
Do you have commit access? If so, please commit the tests only without the code change (and so with baseline CHECK lines), so we can confirm.



================
Comment at: llvm/test/Analysis/ValueTracking/known-non-common-bits.ll:4
+
+define i32 @_Z11and_to_xor1ii(i32 %A, i32 %B) {
+; CHECK-LABEL: @_Z11and_to_xor1ii(
----------------
Remove mangling artifacts (_Z11, 1ii) from all function names.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105013/new/

https://reviews.llvm.org/D105013



More information about the llvm-commits mailing list