[PATCH] D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU.

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added a comment.

In D104730#2867822 <https://reviews.llvm.org/D104730#2867822>, @holland11 wrote:

> In D104730#2866216 <https://reviews.llvm.org/D104730#2866216>, @tstellar wrote:
>
>> I add to add DISABLE_LLVM_LINK_LLVM_DYLIB in two places, in llvm/tools/llvm-mca/lib/AMDGPU/CMakeLists.txt as you did in your comment, and also to the add_llvm_tool call in llvm/tools/llvm-mca/CMakeLists.txt.  When I did that the tests pass.
>
> I really appreciate you testing this for me. Thank you.
>
> @andreadb Would this be reasonable to you? If I understand correctly, this would make it so that `llvm-mca`'s executable wouldn't benefit from shared lib builds. The other alternative would be for me to ask the AMDGPU devs if we can export the specific functions that are being used here. As far as I can tell, those are our only two options.

If that's the case, then your second option is preferable (i.e. exporting those functions that are required by this patch).
I would consider the other alternative only as a last resort.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104730/new/

https://reviews.llvm.org/D104730