[PATCH] D105217: [LLD] Adding support for RELA for CG Profile.

[Alexander Yermolovich via Phabricator via llvm-commits]

ayermolo added inline comments.


================
Comment at: lld/ELF/Driver.cpp:886
+        break;
+      } else if (sec.sh_type == SHT_REL) {
+        ArrayRef<typename ELFT::Rel> rels =
----------------
jhenderson wrote:
> jhenderson wrote:
> > 
> Ping? This hasn't been addressed...
Sorry missed it.


================
Comment at: lld/test/ELF/cgprofile-rela-obj.test:4
+# RUN: yaml2obj %s -o %t.o
+# RUN: ld.lld -e A %t.o -o %t
+# RUN: llvm-nm --no-sort %t | FileCheck %s
----------------
jhenderson wrote:
> You don't need to specify the entry point explicitly. If you really want to suppress the warning, I'd just rename one of the symbols to `_start`.
Hmm. Even with that still got warning: cannot find entry symbol _start; defaulting to 0x201120
Was probably doing something wrong. Just left as Aa.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105217/new/

https://reviews.llvm.org/D105217