[PATCH] D105662: Fix incorrect DWARF 5 file name 0 when using -no-integrated-as

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 9 12:10:20 PDT 2021


dblaikie added a comment.

> But, the md5 argument also relies on the extended syntax, so this isn't actually improving compatibility when using DWARF 5. Fix this bug by always using the directory argument for DWARF 5.

Hmm, I don't think this argument holds - we don't emit checksums by default, do we? They're opt-in, I think? (at the clang level)

So this change as proposed would break that backwards compatibility for assemblers for users who aren't opting in to checksums/haven't already broken it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105662/new/

https://reviews.llvm.org/D105662



More information about the llvm-commits mailing list