[PATCH] D105674: [GlobalISel] Use GCDTy when extracting GCD ty from leftover regs in insertParts

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:229
+  // recalculating GCDTy.
+  LLT GCDTy = extractGCDType(GCDRegs, ResultTy, LeftoverTy, PartRegs[0]);
+  for (auto PartReg : make_range(std::next(PartRegs.begin()), PartRegs.end()))
----------------
I was thinking of just writing out `LLT GCDTy = getGCDType(getGCDType(..., ...), ...);` here to avoid having to do the first reg separately.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105674/new/

https://reviews.llvm.org/D105674