[PATCH] D105545: [MergedLoadStoreMotion] Conditional store elimination

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 9 10:52:41 PDT 2021


chill added a comment.

In D105545#2861643 <https://reviews.llvm.org/D105545#2861643>, @lebedev.ri wrote:

> Warning: this pass clearly modifies CFG, and clearly does not update dominator tree,
> which means you **can not** use dominator tree in this pass,
> at least not until fixing the pass to preserve it when modifying CFG.

Thanks. I think all accesses to the dominator tree (and on the next variants to the MemorySSA graph) occur
before any changes to the CFG.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105545/new/

https://reviews.llvm.org/D105545



More information about the llvm-commits mailing list