[PATCH] D105710: [OpaquePointers][ThreadSanitizer] Cleanup calls to PointerType::getElementType()

Fri Jul 9 10:45:59 PDT 2021

dblaikie added a comment.

In D105710#2867596 <https://reviews.llvm.org/D105710#2867596>, @aeubanks wrote:

> Probably, but I don't think it's worth the time to come up with a test case for every opaque pointer change that doesn't affect existing typed pointer IR. There are a lot of calls in many places throughout LLVM to `PointerType::getElementType()`/`Type::getPointerElementType()`. The important thing is that this is NFC for existing typed pointer IR and we're removing calls to those functions.

I think it's pretty important that we test the changes we're making to demonstrate/ensure they do what we intend.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105710/new/

https://reviews.llvm.org/D105710