[PATCH] D105711: [OpaquePtr][Inline] Use byval type instead of pointee type
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 9 10:42:38 PDT 2021
dblaikie added a comment.
Can this be tested with some opaque pointer IR using byval?
================
Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1896
// Keep a list of pair (dst, src) to emit byval initializations.
- SmallVector<std::pair<Value*, Value*>, 4> ByValInit;
+ SmallVector<std::tuple<Value *, Value *, Type *>, 4> ByValInit;
----------------
Might be reaching the point where a struct with named members would be suitable/more self-documenting?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105711/new/
https://reviews.llvm.org/D105711
More information about the llvm-commits
mailing list