[PATCH] D105691: [Polly][Isl] Use isl::*::ctx instead of isl::*::get_ctx. NFC

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 9 09:31:42 PDT 2021


Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

Could you add the reason for the added `isl::` namespace to the commit message, like in this one:
https://github.com/patacca/isl/commit/b64e33c62d3fe7db506f6630f9e935b663f9c5a4

[suggestion] To avoid the "Lint: pre-merge checks" warnings in `isl-noexceptions.h`, you could make the generator emit `// clang-format off` (https://clang.llvm.org/docs/ClangFormatStyleOptions.html#disabling-formatting-on-a-piece-of-code)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105691/new/

https://reviews.llvm.org/D105691



More information about the llvm-commits mailing list