[PATCH] D105029: [Debug-info][InstrRef] Avoid un-necessary ordering in debug value-substitution records

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 9 07:55:29 PDT 2021


jmorse added a comment.

Thanks for the review; I found at the last minute that the assertion I'd put in MachineFunction.h for detecting duplicate sources in substitutions wasn't going to work: it would also fire when doing lookups. Checking for duplicates needs to be done explicitly; and it's moderately expensive, so I've downgraded it to an EXPENSIVE_CHECK in `InstrRefBasedLDV::initialSetup`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105029/new/

https://reviews.llvm.org/D105029



More information about the llvm-commits mailing list