[PATCH] D105338: [InstCombine] Revert "Temporarily do not drop volatile stores before unreachable"

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

To provide some data on how disruptive this is: https://bugs.chromium.org/p/chromium/issues/detail?id=1227705#c2 (Summary: A naive regex search for `\bvolatile.*(NULL|nullptr).*=` finds this pattern in at least 10 different repositories looking only at chromium code).

So +1 to revert for now, getting numbers on perf to decide if this is worth pursuing at all (they'd have to outweigh the disruption caused), if so then landing the clang warning, waiting a release, and only then landing the llvm change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105338/new/

https://reviews.llvm.org/D105338