[PATCH] D105338: [InstCombine] Revert "Temporarily do not drop volatile stores before unreachable"

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 9 07:24:16 PDT 2021


thakis added a comment.

This seems fairly unfriendly to users. The commit description doesn't say why this change is being made – is there any upside to the change? Is it big enough to justify the downside? Seems weird to land this without mentioning any advantages when the downside is pretty clear :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105338/new/

https://reviews.llvm.org/D105338



More information about the llvm-commits mailing list