[PATCH] D105423: Add support for Opaque as a LowLevelType

[Paulo Matos via Phabricator via llvm-commits]

pmatos added a comment.

In D105423#2864645 <https://reviews.llvm.org/D105423#2864645>, @tlively wrote:

> Nice! This is a lot simpler. I agree that it would be nicer to avoid introducing a new `opaque` concept here entirely, but if fixing up users that depend on zero-sized LLTs to be invalid looks tricky, then this solution seems reasonable.

My idea what to just remove the idea of opaque. I think that a scalar 0 is different from

In D105423#2864645 <https://reviews.llvm.org/D105423#2864645>, @tlively wrote:

> Nice! This is a lot simpler. I agree that it would be nicer to avoid introducing a new `opaque` concept here entirely, but if fixing up users that depend on zero-sized LLTs to be invalid looks tricky, then this solution seems reasonable.

Actually currently the solution is marking RawData as 0 for opaque types without any further special handling so it's actually invalid for those calling `LLT::isValid()`. 
I can remove the concept of opaque and allow 0 sized scalars, but will need a bit for IsScalar. Will give that a go.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105423/new/

https://reviews.llvm.org/D105423