[PATCH] D105027: AArch64: allocate 4-byte slot for arm64_32 pointers during tail call.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 9 02:23:01 PDT 2021


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM thanks! As mentioned in the commit message, this should match the definition in `AArch64CallingConvention.td` which demotes pointers back to `i32`.



================
Comment at: llvm/test/CodeGen/AArch64/swifttail-arm64_32.ll:6
+; CHECK-LABEL: pointer_align_caller:
+; CHECK: b _pointer_align_callee
+  alloca i32
----------------
The test ensures we do not crash in `PrologEpilogInserter` any longer, but it might be good to include check lines for the function & call setups?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105027/new/

https://reviews.llvm.org/D105027



More information about the llvm-commits mailing list