[PATCH] D105598: [llvm-size] Switch command line parsing from llvm::cl to OptTable

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 9 00:50:24 PDT 2021


jhenderson added a comment.

> Note: because the tool is simple, and its long options are uncommon, I just drop

the one-dash forms in this patch.

No objection from me here, but just a thought about Mach-O users: if I'm not mistaken, single-dash long options are the norm on that platform. Might be worth pinging some Mach-O developers about that.



================
Comment at: llvm/tools/llvm-size/llvm-size.cpp:919
+      else {
         outs() << ToolName << ": for the -arch option: Unknown architecture "
+               << "named '" << V << "'";
----------------
(assuming we're dropping long form)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105598/new/

https://reviews.llvm.org/D105598



More information about the llvm-commits mailing list