[PATCH] D75837: [MLIR] Introduce scf.execute_region op

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula marked an inline comment as done.
bondhugula added inline comments.


================
Comment at: mlir/include/mlir/Dialect/SCF/SCFOps.td:114
+  // inline.
+  let hasCanonicalizer = 0;
+
----------------
mehdi_amini wrote:
> Seems like a canonicalization could be that it would return an SSA value defined in the enclosing region.
Did you mean moving the slice that generates the yield values to the enclosing region (if they were inside the scf.execute_region)? This can't be done in O(1) time in general nor are the utilities that allow one to do that available in IR libraries - can be part of `Transforms/` though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75837/new/

https://reviews.llvm.org/D75837