[PATCH] D105453: [mlir][SystemZ] Disable `-fno-semantic-interposition` option.

[Haruki Imai via Phabricator via llvm-commits]

imaihal updated this revision to Diff 357411.
imaihal marked an inline comment as done.
imaihal added a comment.

Updated the comment again to reflect @MaskRay`s comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105453/new/

https://reviews.llvm.org/D105453

Files:
  llvm/cmake/modules/HandleLLVMOptions.cmake


Index: llvm/cmake/modules/HandleLLVMOptions.cmake
===================================================================
--- llvm/cmake/modules/HandleLLVMOptions.cmake
+++ llvm/cmake/modules/HandleLLVMOptions.cmake
@@ -318,8 +318,11 @@
     # Older Clang may support -fno-semantic-interposition but it used local
     # aliases to optimize global variables, which is incompatible with copy
     # relocations due to -fno-pic.
-    if (CMAKE_COMPILER_IS_GNUCXX OR (CMAKE_CXX_COMPILER_ID MATCHES "Clang" AND
-        CMAKE_CXX_COMPILER_VERSION GREATER_EQUAL 13))
+    # GCC<10.3 has bugs on SystemZ, so don't use the option for older GCC.
+    if ((CMAKE_COMPILER_IS_GNUCXX AND
+	  NOT (LLVM_NATIVE_ARCH STREQUAL "SystemZ"
+	    AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 10.3))
+	OR (CMAKE_CXX_COMPILER_ID MATCHES "Clang" AND CMAKE_CXX_COMPILER_VERSION GREATER_EQUAL 13))
       add_flag_if_supported("-fno-semantic-interposition" FNO_SEMANTIC_INTERPOSITION)
     endif()
   endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105453.357411.patch
Type: text/x-patch
Size: 980 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210709/e4d1e834/attachment-0001.bin>