[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

[Amy Kwan via Phabricator via llvm-commits]

amyk added inline comments.


================
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-fp.c:3
+// RUN: %clang_cc1 -triple powerpc64-unknown-unknown \
+// RUN: -emit-llvm %s -o - -target-cpu pwr7 | FileCheck %s
+// RUN: %clang_cc1 -triple powerpc64le-unknown-unknown \
----------------
nit: indentation on every second run line. We usually do two spaces more than the previous line. So I think it would look like:



================
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-fp.c:19
+// CHECK-LABEL: @test_fric(
+// CHECK-NEXT:  entry:
+// CHECK-NEXT:    [[TMP0:%.*]] = load double, double* @a, align 8
----------------
Do the `entry` lines cause an issue when we don't have asserts?


================
Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1529
+                     Intrinsic<[llvm_double_ty], [llvm_double_ty, 
+                     llvm_double_ty, llvm_double_ty], [IntrNoMem]>;
+  def int_ppc_fsels : GCCBuiltin<"__builtin_ppc_fsels">,
----------------
Minor indentation nit.


================
Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1532
+                      Intrinsic<[llvm_float_ty], [llvm_float_ty, llvm_float_ty,
+                      llvm_float_ty], [IntrNoMem]>;
+  def int_ppc_frsqrte : GCCBuiltin<"__builtin_ppc_frsqrte">,
----------------
Minor indentation nit to make it aligned with above.


================
Comment at: llvm/test/CodeGen/builtins-ppc-xlcompat-fp.ll:2
+; RUN: llc -verify-machineinstrs -mtriple=powerpc64-unknown-unknown \
+; RUN: -mcpu=pwr7 < %s | FileCheck %s --check-prefix=CHECK-PWR7
+; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-unknown \
----------------
Minor indentation nit: 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103986/new/

https://reviews.llvm.org/D103986