[PATCH] D105338: [InstCombine] Revert "Temporarily do not drop volatile stores before unreachable"

[Krzysztof Parzyszek via Phabricator via llvm-commits]

kparzysz added a comment.

In D105338#2865673 <https://reviews.llvm.org/D105338#2865673>, @lebedev.ri wrote:

> That could be a very simple diag, and it could be useful i suppose,
> but as seen in GWP-ASan case, it won't help people potentially expecting any volatile store trapping.

There is also a related diagnostic that needs to be fixed, since it suggests the volatile approach:

  rtt.cc:2:3: warning: indirection of non-volatile null pointer will be deleted, not trap [-Wnull-dereference]
    *reinterpret_cast<int*>(0) = 0;
    ^~~~~~~~~~~~~~~~~~~~~~~~~~
  rtt.cc:2:3: note: consider using __builtin_trap() or qualifying pointer with 'volatile'


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105338/new/

https://reviews.llvm.org/D105338