[PATCH] D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU.

Patrick Holland via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 8 14:42:43 PDT 2021


holland11 added a comment.

@tstellar Would you be willing to test the fix for me? If this request is inappropriate then I can setup a VM and reproduce the error myself then test the fix, but if you're willing to test it for me, that'd be awesome.

  > git checkout af3baf1761bb

To get back to this commit.

Then modify `/llvm/tools/llvm-mca/lib/AMDGPU/CMakeLists.txt` to be

  include_directories(
    ${LLVM_MAIN_SRC_DIR}/lib/Target/AMDGPU
    ${LLVM_BINARY_DIR}/lib/Target/AMDGPU
    )
  
  set(LLVM_LINK_COMPONENTS
    AMDGPU
    Core
    MCA
    Support
    )
  
  add_llvm_library(LLVMMCACustomBehaviourAMDGPU
    DISABLE_LLVM_LINK_LLVM_DYLIB
    
    AMDGPUCustomBehaviour.cpp
  
    DEPENDS
    AMDGPUCommonTableGen
    )

Then see if the error is gone when building with shared libs.

But again, I'd like to emphasize that if you're busy or this is just an inconsiderate request by me, then I can test it myself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104730/new/

https://reviews.llvm.org/D104730



More information about the llvm-commits mailing list