[PATCH] D105217: [LLD] Adding support for RELA for CG Profile.

Thu Jul 8 14:11:53 PDT 2021

ayermolo added a comment.

In D105217#2863821 <https://reviews.llvm.org/D105217#2863821>, @jhenderson wrote:

> Test case(s) for the LLD portion of this patch?

There doesn't seem to be any tests for LLD, even for old implementation. What would be best way? feed llvm bit code in to llvm-mc, run lld on it and check final binary symbol table for ordering? Add something to LLD to output from internal data structure?

================
Comment at: lld/ELF/InputFiles.h:24
 #include "llvm/Support/Threading.h"
+#include <cstdint>
 #include <map>
----------------
jhenderson wrote:
> Do you need to add this include? My understanding of the style guide is that you don't need to add it, unless the code doesn't compile without (it is likely pulled in by other headers).
ugh, sneaked in somehow.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105217/new/

https://reviews.llvm.org/D105217