[PATCH] D105176: [InstrProfiling] Use external weak reference for bias variable

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 8 13:48:15 PDT 2021


phosek added a comment.

In D105176#2865370 <https://reviews.llvm.org/D105176#2865370>, @MaskRay wrote:

>> We also disable the use of runtime counter relocation on Darwin since Mach-O doesn't support weak external references, but Darwin already uses a different continous mode that relies on overmapping so runtime counter relocation isn't needed there.
>
> I think you can restrict undefined weak to ELF now. PE-COFF doesn't have undefined weak, either.

Done, do you know if there's any alternative we could use for PE-COFF?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105176/new/

https://reviews.llvm.org/D105176



More information about the llvm-commits mailing list