[PATCH] D105338: [InstCombine] Revert "Temporarily do not drop volatile stores before unreachable"

[Krzysztof Parzyszek via Phabricator via llvm-commits]

kparzysz added a comment.

In D105338#2865215 <https://reviews.llvm.org/D105338#2865215>, @chandlerc wrote:

> In D105338#2864865 <https://reviews.llvm.org/D105338#2864865>, @spatel wrote:
>
>> If the goal is to get source like that to change, then we might as well fix that first, so we can point to it as a reference example of how to fix code?
>
> I really don't know how to change that code in a meaningful way. It is already marking the store as volatile (in the C sense).

We have `__builtin_trap` that's supposed to do something similar.  If they need a SEGV specifically (i.e. this is a unix-like OS), they can use `kill(getpid(), SIGSEGV)`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105338/new/

https://reviews.llvm.org/D105338