[PATCH] D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU.

Thu Jul 8 11:29:41 PDT 2021

holland11 added a comment.

@tstellar I have been unable to reproduce the error on my machine. I checked out my repo to this commit and tried building with

  cmake -GNinja -DCMAKE_BUILD_TYPE=Debug -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_BUILD_LLVM_DYLIB=ON -DLLVM_LINK_LLVM_DYLIB=ON ../../llvm
  ninja

But it built without errors. I then tried the same thing, but with `-DLLVM_TARGETS_TO_BUILD="X86"` to see if it was related to building without AMDGPU, but that also built without issue.

I would like to reproduce the error so that when I attempt your fix, I can verify that it actually worked. Do you have any suggestions for how I can reproduce the problem? I've never built with shared libs before so I'm not sure if my build commands are correct. Also, I'm on macOS if that makes any difference.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104730/new/

https://reviews.llvm.org/D104730