[PATCH] D105560: Add disassembly for the conditioned move immediate instruction for the ARC backend

[Thomas Johnson via Phabricator via llvm-commits]

thomasjohns added inline comments.


================
Comment at: llvm/lib/Target/ARC/Disassembler/ARCDisassembler.cpp:110
 
+static DecodeStatus DecodeCCRU6Instruction(MCInst &, uint64_t, uint64_t,
+                                           const void *);
----------------
The recommendation for this lint is to move to `decodeCCRU6Instruction`. However, most backends seem to follow the `Decode*` naming convention and we do too for other Decode methods.

Changing all our methods to `decode*` is one option (PowerPC does this), though it will increase the diff size by a fair amount.

Another option is to add `// NOLINTNEXTLINE(readability-identifier-naming)` comments which the AMDGPU backend does.

I feel like other backends might have either ignored this or have submitted code before the clang-tidy pre-merge check was around.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105560/new/

https://reviews.llvm.org/D105560