[PATCH] D105461: [Support] CommandLine.cpp - Fix thread race condition in addOption
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 8 10:02:06 PDT 2021
mehdi_amini added a comment.
> I think the problem is larger than this fix implies. I don't think this spot fix is the right approach. In the long run, it will make it harder to implement a comprehensive design for thread safety.
That's my sentiment as well, I'm wary of just patching over without stepping back and looking at this a bit more globally.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105461/new/
https://reviews.llvm.org/D105461
More information about the llvm-commits
mailing list