[PATCH] D105571: [AArch64][SME] Add outer product instructions

[Kerry McLaughlin via Phabricator via llvm-commits]

kmclaughlin added inline comments.


================
Comment at: llvm/test/MC/AArch64/SME/bfmopa-diagnostics.s:18
+// CHECK-NOT: [[@LINE-1]]:{{[0-9]+}}:
+
+bfmopa za0.s, p0/m, p8/m, z0.h, z0.h
----------------
Should there also be tests included here (and in the diagnostic tests for other instructions in this patch) for predicates with an incorrect suffix, i.e. `/z`?


================
Comment at: llvm/test/MC/AArch64/SME/fmopa-diagnostics.s:4
+// ------------------------------------------------------------------------- //
+// Invalid tile
+
----------------
For some other tests (such as smopa-diagnostics.s) you've added details of the valid tiles for each variant in the comments and I think that would be useful here too, i.e.
```
// Invalid tile
//
// .s => za0-za3, .d => za0-za7
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105571/new/

https://reviews.llvm.org/D105571