[PATCH] D105262: [ARM] Use matchSimpleRecurrence to simplify some code in MVEGatherScatterLowering. NFCI

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 8 09:24:14 PDT 2021


dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Oh yeah, I've seen shr come up before too. That was from gathers produced from x[i/2]. It's not one that we've got to yet. Constant factors of 2 are less common under MVE I think, because would usually use VLD2 instead.

> So far just the code to push computations out of the loop.

Yesh, the other half of this might be pretty MVE specific, lowering the gathers to intrinsics. The exact forms of gathers supported in MVE is sometimes quite specific, and can require some of the optimizations here to lower them nicely.

This patch LGTM from what I can tell about matchSimpleRecurrence. Thanks for putting it together.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105262/new/

https://reviews.llvm.org/D105262



More information about the llvm-commits mailing list