[PATCH] D105461: [Support] CommandLine.cpp - Fix thread race condition in addOption

Thu Jul 8 03:54:36 PDT 2021

aaron.ballman accepted this revision.
aaron.ballman added reviewers: hokein, rnk.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

Thanks for the fix! This LGTM as far as the change goes, though I wonder if there are other race conditions hiding in this file. I'm not an expert in this particular area, so you should wait a few days before landing in case any of the other reviewers have comments (I added a few more folks who have touched this file in recent history).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105461/new/

https://reviews.llvm.org/D105461