[PATCH] D105590: [amdgpu] Remove the GlobalDCE pass prior to the internalization pass.

[Jay Foad via Phabricator via llvm-commits]

foad accepted this revision.
foad added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:434
 
+  GV.removeDeadConstantUsers();
   return !GV.use_empty();
----------------
hliao wrote:
> rampitec wrote:
> > Maybe do this in the InternalizePass itself? This is a predicate function and it is not expected to change the IR.
> In fact, even there are dead constants removed, the IR won't be changed. IR printer won't be able to print those dead constant users from this GV.
Agreed, I think this is the right way to do this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105590/new/

https://reviews.llvm.org/D105590