[PATCH] D105423: Add support for Opaque as a LowLevelType
Paulo Matos via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 8 00:15:25 PDT 2021
pmatos added inline comments.
================
Comment at: llvm/include/llvm/Support/LowLevelTypeImpl.h:293-294
/// described in static const *Field variables. Each of these variables
- /// is a 2-element array, with the first element describing the bitfield size
+ /// is a 3-element array, with the first element describing the bitfield size
/// and the second element describing the bitfield offset.
+ typedef int BitFieldInfo[3];
----------------
tlively wrote:
> Why did the number of elements change? What is the third element for? It would be good to update the comment.
I misunderstood the point of this array. Reverting the change. Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105423/new/
https://reviews.llvm.org/D105423
More information about the llvm-commits
mailing list