[PATCH] D105006: [NewPM] Handle passes with params in -print-before/-print-after

[Yuanfang Chen via Phabricator via llvm-commits]

ychen added inline comments.


================
Comment at: llvm/test/Other/print-before-after.ll:39
+; mapping, so we do not get the -print-before=unswitch printout here.
+; XXXCHECK-UNSWITCH: *** IR Dump Before SimpleLoopUnswitchPass on Loop at depth 1 containing
+; CHECK-UNSWITCH: *** IR Dump After SimpleLoopUnswitchPass on Loop at depth 1 containing
----------------
bjope wrote:
> ychen wrote:
> > `XXXCHECK-UNSWITCH`?
> Those are the printouts that still are missing, as explained in the FIXME. The goal would be to enable those checks by removing the "XXX". But then we need to remove the "unswitch" alias for "simple-loop-unswitch".
I'd use `CHECK-UNSWITCH-NOT`. It is unusual to use unchecked labels.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105006/new/

https://reviews.llvm.org/D105006