[PATCH] D105598: [llvm-size] Switch command line parsing from llvm::cl to OptTable

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 7 16:05:30 PDT 2021


MaskRay created this revision.
MaskRay added a reviewer: jhenderson.
Herald added subscribers: rupprecht, mgorny.
MaskRay requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Part of https://lists.llvm.org/pipermail/llvm-dev/2021-July/151622.html
"Binary utilities: switch command line parsing from llvm::cl to OptTable"

- `--totals=false` and `--totals=0` cannot be used. Omit the option.
- `--help-list` is removed. This is a `cl::` specific option.

OptTable avoids global option collision if we decide to support multiplexing for binary utilities.

Note: because the tool is simple, and its long options are uncommon, I just drop
the one-dash forms in this patch.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D105598

Files:
  llvm/test/tools/llvm-size/help.test
  llvm/test/tools/llvm-size/radix.test
  llvm/test/tools/llvm-size/unknown-format.test
  llvm/tools/llvm-size/CMakeLists.txt
  llvm/tools/llvm-size/llvm-size.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105598.357099.patch
Type: text/x-patch
Size: 10949 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210707/29b46368/attachment.bin>


More information about the llvm-commits mailing list