[PATCH] D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type
Nick Fitzgerald via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 7 14:48:25 PDT 2021
fitzgen updated this revision to Diff 357083.
fitzgen added a comment.
Updated based on review feedback:
- Removed `--allow-undefined` and `--no-gc-sections` from `duplicate-global-imports.s`
- Added `global.get`s for each global in `duplicate-global-imports.s`
- Switched to `--export-all` instead of explicitly listing each export in `duplicate-table-imports.s`
- Renamed `alreadyImportedStuff` to `importedStuff`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105519/new/
https://reviews.llvm.org/D105519
Files:
lld/test/wasm/duplicate-function-imports.ll
lld/test/wasm/duplicate-global-imports.s
lld/test/wasm/duplicate-table-imports.s
lld/wasm/SyntheticSections.cpp
lld/wasm/SyntheticSections.h
llvm/include/llvm/BinaryFormat/Wasm.h
llvm/include/llvm/BinaryFormat/WasmTraits.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105519.357083.patch
Type: text/x-patch
Size: 15648 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210707/71a02b63/attachment.bin>
More information about the llvm-commits
mailing list