[PATCH] D105519: [WebAssembly] Deduplicate imports of the same module name, field name, and type

[Nick Fitzgerald via Phabricator via llvm-commits]

fitzgen marked 5 inline comments as done.
fitzgen added inline comments.


================
Comment at: lld/test/wasm/duplicate-table-imports.s:2
+# RUN: llvm-mc -mattr=+reference-types -triple=wasm32-unknown-unknown -filetype=obj -o %t.o %s
+# RUN: wasm-ld --no-entry --allow-undefined --export=read_externref --export=read_funcref_1 --export=read_funcref_2 -o %t1.wasm %t.o
+# RUN: obj2yaml %t1.wasm | FileCheck %s
----------------
fitzgen wrote:
> sbc100 wrote:
> > Can you remove `--allow-undefined` ?   And maybe you can `--export-all` rather then exporting each one ?
> Will do.
I switched to `--export-all` rather than explicitly enumerating each export, but removing `--allow-undefined` makes it error out because the `t{1,2,3}` symbols are undefined, and I don't know how to make a defined, imported table in a `.s`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105519/new/

https://reviews.llvm.org/D105519