[PATCH] D105246: [AbstractAttributor] Fold function calls to `__kmpc_is_spmd_exec_mode` if possible

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

Test still missing ;)



================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:3244
+      updateSPMDFolding(A);
+
     // Callback to check a call instruction.
----------------
jdoerfert wrote:
> Why `!assumed()` ? Wouldn't that mean we only update if we have unknown reaching kernels?
This is better but I'm still not sure if it's correct. When we go from valid to invalid we stop updating the map, which is bad because the content is still in there. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105246/new/

https://reviews.llvm.org/D105246