[PATCH] D105506: [LLD] [COFF] Avoid thread exhaustion on 32-bit Windows host
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 7 12:01:06 PDT 2021
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7a7da69fbe28: [LLD] [COFF] Avoid thread exhaustion on 32-bit Windows host (authored by jeremyd2019, committed by mstorsjo).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105506/new/
https://reviews.llvm.org/D105506
Files:
lld/COFF/Driver.cpp
Index: lld/COFF/Driver.cpp
===================================================================
--- lld/COFF/Driver.cpp
+++ lld/COFF/Driver.cpp
@@ -149,9 +149,10 @@
// Create a std::future that opens and maps a file using the best strategy for
// the host platform.
static std::future<MBErrPair> createFutureForFile(std::string path) {
-#if _WIN32
+#if _WIN64
// On Windows, file I/O is relatively slow so it is best to do this
- // asynchronously.
+ // asynchronously. But 32-bit has issues with potentially launching tons
+ // of threads
auto strategy = std::launch::async;
#else
auto strategy = std::launch::deferred;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105506.357034.patch
Type: text/x-patch
Size: 637 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210707/ec16b366/attachment.bin>
More information about the llvm-commits
mailing list